[DNM] adsp: add configuration to adsp virtual regions by marcinszkudlinski · Pull Request #91666 · zephyrproject-rtos/zephyr

marcinszkudlinski · 2025-06-16T07:59:32Z

virtual region feature in intel ADSP has no config options There's always a region per-core, a shared and
an opportunistic region.
All regions have a hard-coded sizes. There's also a defect: shared region gets its size from CORE_HEAP_SIZE macro

This commit adds kconfig options that allow enabling of each regions separately, as well as adjusting their sizes

Copilot

Pull Request Overview

Adds Kconfig-driven controls for virtual memory regions in Intel ADSP, replacing hard-coded sizes and enabling per-core, shared, and opportunistic regions.

Introduce new enable/size Kconfig options for per-core, shared, and opportunistic regions
Update adsp_memory_regions.h to compute VIRTUAL_REGION_COUNT from those options
Refactor mm_drv_intel_adsp_regions.c to size and initialize regions using the new config macros

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
soc/intel/intel_adsp/ace/include/adsp_memory_regions.h	Compute region counts and attributes from Kconfig instead of hard codes
drivers/mm/mm_drv_intel_adsp_regions.c	Resize region array and update `append_region` calls to use config
drivers/mm/Kconfig	Add Kconfig options for enabling and sizing each virtual memory region

Comments suppressed due to low confidence (3)

drivers/mm/mm_drv_intel_adsp_regions.c:47

Using i - 1 when i == 0 (e.g., if per-core regions are disabled) can underflow the index and access out-of-bounds. Consider tracking the last region address via total_size or ensure i > 0 before using i - 1.

append_region((void *)((uintptr_t)virtual_memory_regions[i - 1].addr +

drivers/mm/mm_drv_intel_adsp_regions.c:61

Typo in comment: 'Apending' should be 'Appending'.

/* Apending last region as 0 so iterators know where table is over

soc/intel/intel_adsp/ace/include/adsp_memory_regions.h:12

Typo in comment: 'Attribiutes' should be 'Attributes'.

/* Attribiutes for memory regions */

Copilot · 2025-06-16T08:01:42Z

+	bool "Support for opportunstic virtual memory region"
+	depends on MM_DRV_INTEL_ADSP_MTL_TLB
+	default y
+	help
+	  This config enables opportunstic virtual memory region
+
+config MM_DRV_INTEL_ADSP_TLB_VIRTUAL_MEMORY_OPPORTUNISTIC_REGION_SIZE
+	hex "Size in bytes of opportunstic virtual memory region"
+	depends on MM_DRV_INTEL_ADSP_TLB_USE_VIRTUAL_MEMORY_OPPORTUNISTIC_REGION
+	default 0x100000
+	help
+	  This config defines size of opportunstic virtual memory region


Typo in menu prompt: 'opportunstic' should be 'opportunistic'.

Suggested change

bool "Support for opportunstic virtual memory region"

depends on MM_DRV_INTEL_ADSP_MTL_TLB

default y

help

This config enables opportunstic virtual memory region

config MM_DRV_INTEL_ADSP_TLB_VIRTUAL_MEMORY_OPPORTUNISTIC_REGION_SIZE

hex "Size in bytes of opportunstic virtual memory region"

depends on MM_DRV_INTEL_ADSP_TLB_USE_VIRTUAL_MEMORY_OPPORTUNISTIC_REGION

default 0x100000

help

This config defines size of opportunstic virtual memory region

bool "Support for opportunistic virtual memory region"

depends on MM_DRV_INTEL_ADSP_MTL_TLB

default y

help

This config enables opportunistic virtual memory region

config MM_DRV_INTEL_ADSP_TLB_VIRTUAL_MEMORY_OPPORTUNISTIC_REGION_SIZE

hex "Size in bytes of opportunistic virtual memory region"

depends on MM_DRV_INTEL_ADSP_TLB_USE_VIRTUAL_MEMORY_OPPORTUNISTIC_REGION

default 0x100000

help

This config defines size of opportunistic virtual memory region

Copilot · 2025-06-16T08:01:42Z

+	bool "Support for opportunstic virtual memory region"
+	depends on MM_DRV_INTEL_ADSP_MTL_TLB
+	default y
+	help
+	  This config enables opportunstic virtual memory region
+
+config MM_DRV_INTEL_ADSP_TLB_VIRTUAL_MEMORY_OPPORTUNISTIC_REGION_SIZE
+	hex "Size in bytes of opportunstic virtual memory region"
+	depends on MM_DRV_INTEL_ADSP_TLB_USE_VIRTUAL_MEMORY_OPPORTUNISTIC_REGION
+	default 0x100000
+	help
+	  This config defines size of opportunstic virtual memory region


Typo in help text: 'opportunstic' should be 'opportunistic'.

Suggested change

bool "Support for opportunstic virtual memory region"

depends on MM_DRV_INTEL_ADSP_MTL_TLB

default y

help

This config enables opportunstic virtual memory region

config MM_DRV_INTEL_ADSP_TLB_VIRTUAL_MEMORY_OPPORTUNISTIC_REGION_SIZE

hex "Size in bytes of opportunstic virtual memory region"

depends on MM_DRV_INTEL_ADSP_TLB_USE_VIRTUAL_MEMORY_OPPORTUNISTIC_REGION

default 0x100000

help

This config defines size of opportunstic virtual memory region

bool "Support for opportunistic virtual memory region"

depends on MM_DRV_INTEL_ADSP_MTL_TLB

default y

help

This config enables opportunistic virtual memory region

config MM_DRV_INTEL_ADSP_TLB_VIRTUAL_MEMORY_OPPORTUNISTIC_REGION_SIZE

hex "Size in bytes of opportunistic virtual memory region"

depends on MM_DRV_INTEL_ADSP_TLB_USE_VIRTUAL_MEMORY_OPPORTUNISTIC_REGION

default 0x100000

help

This config defines size of opportunistic virtual memory region

Copilot · 2025-06-16T08:01:42Z

+	bool "Support for opportunstic virtual memory region"
+	depends on MM_DRV_INTEL_ADSP_MTL_TLB
+	default y
+	help
+	  This config enables opportunstic virtual memory region
+
+config MM_DRV_INTEL_ADSP_TLB_VIRTUAL_MEMORY_OPPORTUNISTIC_REGION_SIZE
+	hex "Size in bytes of opportunstic virtual memory region"
+	depends on MM_DRV_INTEL_ADSP_TLB_USE_VIRTUAL_MEMORY_OPPORTUNISTIC_REGION
+	default 0x100000
+	help
+	  This config defines size of opportunstic virtual memory region


Typo in prompt: 'opportunstic' should be 'opportunistic'.

Suggested change

bool "Support for opportunstic virtual memory region"

depends on MM_DRV_INTEL_ADSP_MTL_TLB

default y

help

This config enables opportunstic virtual memory region

config MM_DRV_INTEL_ADSP_TLB_VIRTUAL_MEMORY_OPPORTUNISTIC_REGION_SIZE

hex "Size in bytes of opportunstic virtual memory region"

depends on MM_DRV_INTEL_ADSP_TLB_USE_VIRTUAL_MEMORY_OPPORTUNISTIC_REGION

default 0x100000

help

This config defines size of opportunstic virtual memory region

bool "Support for opportunistic virtual memory region"

depends on MM_DRV_INTEL_ADSP_MTL_TLB

default y

help

This config enables opportunistic virtual memory region

config MM_DRV_INTEL_ADSP_TLB_VIRTUAL_MEMORY_OPPORTUNISTIC_REGION_SIZE

hex "Size in bytes of opportunistic virtual memory region"

depends on MM_DRV_INTEL_ADSP_TLB_USE_VIRTUAL_MEMORY_OPPORTUNISTIC_REGION

default 0x100000

help

This config defines size of opportunistic virtual memory region

virtual region feature in intel ADSP has no config options There's always a region per-core, a shared and an opportunistic region. All regions have a hard-coded sizes. There's also a defect: shared region gets its size from CORE_HEAP_SIZE macro This commit adds kconfig options that allow enabling of each regions separately, as well as adjusting their sizes Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>

sonarqubecloud · 2025-06-16T08:20:53Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

softwarecki · 2025-06-16T16:07:00Z

+#endif

+#if CONFIG_MM_DRV_INTEL_ADSP_TLB_USE_VIRTUAL_MEMORY_SHARED_REGION
 	append_region((void *)((uintptr_t)virtual_memory_regions[i - 1].addr +


Hey! If CONFIG_MM_DRV_INTEL_ADSP_TLB_USE_PER_CORE_VIRTUAL_MEMORY_REGIONS is not active, then i will have value 0 and it will reference to element -1 of the virtual_memory_regions array.

softwarecki

In my opinion the entire calculate_memory_regions function is unnecessary, and the sys_mm_drv_query_memory_regions array can be statically initialized (for cores heap use the LISTIFY macro).

BTW: The append_region function adds the size to a pointer instead of to the total_size variable value. @dabekjakub

lyakh · 2025-06-17T07:23:43Z

+#define VIRTUAL_REGION_COUNT_PER_CORE CONFIG_MP_MAX_NUM_CPUS
 #define MEM_REG_ATTR_CORE_HEAP 1U
+#else
+#define VIRTUAL_REGION_COUNT_PER_CORE 0


if selected, this option would break SOF - both with and without thesofproject/sof#10044

marcinszkudlinski · 2025-06-17T07:33:05Z

Added [DNM] - we need to sync with SOF

marcinszkudlinski requested review from Copilot and lyakh and removed request for Copilot June 16, 2025 07:59

github-actions Bot added platform: Intel ADSP Intel Audio platforms area: Memory Management labels Jun 16, 2025

github-actions Bot requested review from andyross, ceolin, dcpleung, edersondisouza, jxstelter, kv2019i, lgirdwood, nashif, softwarecki and tmleman June 16, 2025 08:00

github-actions Bot assigned dcpleung Jun 16, 2025

marcinszkudlinski mentioned this pull request Jun 16, 2025

Cross core Virtual heaps, invalidation of cross core buffers in unbind call thesofproject/sof#10044

Merged

Copilot AI reviewed Jun 16, 2025

View reviewed changes

marcinszkudlinski force-pushed the kconfig_virt_mem branch from 30413f0 to b96d265 Compare June 16, 2025 08:17

softwarecki reviewed Jun 16, 2025

View reviewed changes

softwarecki requested changes Jun 16, 2025

View reviewed changes

lyakh reviewed Jun 17, 2025

View reviewed changes

marcinszkudlinski changed the title ~~adsp: add configuration to adsp virtual regions~~ [DNM] adsp: add configuration to adsp virtual regions Jun 17, 2025

marcinszkudlinski closed this Jul 8, 2025

marcinszkudlinski deleted the kconfig_virt_mem branch July 8, 2025 11:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DNM] adsp: add configuration to adsp virtual regions#91666

[DNM] adsp: add configuration to adsp virtual regions#91666
marcinszkudlinski wants to merge 1 commit intozephyrproject-rtos:mainfrom
marcinszkudlinski:kconfig_virt_mem

marcinszkudlinski commented Jun 16, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jun 16, 2025

Uh oh!

Copilot AI Jun 16, 2025

Uh oh!

Copilot AI Jun 16, 2025

Uh oh!

sonarqubecloud Bot commented Jun 16, 2025

Uh oh!

softwarecki Jun 16, 2025

Uh oh!

softwarecki left a comment

Uh oh!

lyakh Jun 17, 2025

Uh oh!

marcinszkudlinski commented Jun 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

marcinszkudlinski commented Jun 16, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jun 16, 2025

Quality Gate passed

Uh oh!

softwarecki Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

softwarecki left a comment

Choose a reason for hiding this comment

Uh oh!

lyakh Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

marcinszkudlinski commented Jun 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants