Skip to content

Adding a missing conversion for elementID on paint example#46550

Closed
jaredwy wants to merge 1 commit intozed-industries:mainfrom
jaredwy:main
Closed

Adding a missing conversion for elementID on paint example#46550
jaredwy wants to merge 1 commit intozed-industries:mainfrom
jaredwy:main

Conversation

@jaredwy
Copy link
Copy Markdown

@jaredwy jaredwy commented Jan 11, 2026

Relatively new to gpui, but looking at an example on windows and found this compilation error. Hope this is the right way to contribute the patch.

Release Notes:

  • Fixed A compilation error in the gpui example painting.

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Jan 11, 2026

We require contributors to sign our Contributor License Agreement, and we don't have @jaredwy on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@jaredwy
Copy link
Copy Markdown
Author

jaredwy commented Jan 11, 2026

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jan 11, 2026
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Jan 11, 2026

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Copy Markdown
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on the "compilation error" a bit?

We do check the examples in CI it seems:

- name: cargo build --workspace --bins --examples
run: cargo build --workspace --bins --examples
shell: bash -euxo pipefail {0}
- name: steps::cleanup_cargo_config
if: always()
run: |
rm -rf ./../.cargo
shell: bash -euxo pipefail {0}

And building the example locally with cargo run -p gpui --example painting works for me.

@SomeoneToIgnore SomeoneToIgnore self-assigned this Jan 11, 2026
@jaredwy
Copy link
Copy Markdown
Author

jaredwy commented Jan 11, 2026

@SomeoneToIgnore I thought it was a bit odd but also couldn't find an implicit conversion anywhere. The error was on the line that's changed, saying no conversion from string to elementIDs. This is also how elementIDs are created in other examples.

The one difference perhaps, is I was not building it inside the workspace, but copied the file into my own project and included gpui that way.

I should have some time this afternoon to try it out inside the project vs out as well as on mac (although can't see why that would be any different)

@SomeoneToIgnore
Copy link
Copy Markdown
Contributor

Indeed, thank you for the pointer: if I crate a standalone project, do cargo add gpui there and get gpui = "0.2.2", it cannot compile the example's code copied over into main.

I am not sure though, if we should adjust the examples to fix this: sounds like another gpui release is needed instead.

@SomeoneToIgnore
Copy link
Copy Markdown
Contributor

Oh yeah, we have #46183 and an assignee there.

I believe the real fix would be to publish the newer version?
That would require more than a PR I'm afraid, hence will close the PR.
@\miguelraz should take care of this situation eventually it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants