Adding a missing conversion for elementID on paint example#46550
Adding a missing conversion for elementID on paint example#46550jaredwy wants to merge 1 commit intozed-industries:mainfrom
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @jaredwy on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
SomeoneToIgnore
left a comment
There was a problem hiding this comment.
Can you elaborate on the "compilation error" a bit?
We do check the examples in CI it seems:
zed/.github/workflows/run_tests.yml
Lines 281 to 288 in af6385a
And building the example locally with cargo run -p gpui --example painting works for me.
|
@SomeoneToIgnore I thought it was a bit odd but also couldn't find an implicit conversion anywhere. The error was on the line that's changed, saying no conversion from string to elementIDs. This is also how elementIDs are created in other examples. The one difference perhaps, is I was not building it inside the workspace, but copied the file into my own project and included gpui that way. I should have some time this afternoon to try it out inside the project vs out as well as on mac (although can't see why that would be any different) |
|
Indeed, thank you for the pointer: if I crate a standalone project, do I am not sure though, if we should adjust the examples to fix this: sounds like another gpui release is needed instead. |
|
Oh yeah, we have #46183 and an assignee there. I believe the real fix would be to publish the newer version? |
Relatively new to gpui, but looking at an example on windows and found this compilation error. Hope this is the right way to contribute the patch.
Release Notes: