Draft
Conversation
Contributor
Author
|
cc @emmaualemalthot |
d-v-b
commented
Mar 13, 2026
| raise ValueError(f"Unknown rounding mode: {mode}") | ||
|
|
||
|
|
||
| def _cast_array( |
Contributor
Author
There was a problem hiding this comment.
this implementation is inefficient and will probably remain so as long as we are using python for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
scale_offsetandcast_valuecodecs. Used together, these codecs replace thefixedscaleoffsetcodec defined in numcodecs.closes #3772
as an experiment, I'm including some developer notes I had claude write in the commit history. We can remove them before merging if we don't want that kind of thing sticking around.