-
-
Notifications
You must be signed in to change notification settings - Fork 400
Fill missing chunks #3748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fill missing chunks #3748
Changes from 9 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
a07764e
Add `codec_pipeline.fill_missing_chunks` config
tomwhite 7438a03
Set default for `fill_missing_chunks` in config.py. Add test replicating
williamsnell 38e5acf
Add fill_missing_chunks to examples of config options.
williamsnell 1d51b37
Add to /changes
williamsnell ad3e2ed
Parameterize tests to make sure we hit both branches of `if
williamsnell 2c9b31b
Fix lint errors: remove parentheses, type kwargs.
williamsnell 2846ed9
Move config from codec_pipeline -> array. Update docs, tests.
williamsnell de7afd8
Delegate missing-shard detection away from _get_chunk_spec. Codify
williamsnell 233ddce
Merge branch 'main' into fill-missing-chunks
williamsnell c8b0d11
Merge branch 'main' into fill-missing-chunks
d-v-b d460521
Define ChunkNotFoundError; expose chunk key and chunk index in ChunkN…
d-v-b 9c9a096
update docs
d-v-b 40da713
Merge branch 'fill-missing-chunks' of https://github.com/williamsnell…
d-v-b 16517d1
Merge branch 'main' into fill-missing-chunks
d-v-b 70b7c7b
fix links
d-v-b 338a494
Merge branch 'fill-missing-chunks' of https://github.com/williamsnell…
d-v-b 8f2cdc4
cleanup
d-v-b df73f2a
Merge branch 'main' into fill-missing-chunks
williamsnell 332ddc2
Merge branch 'main' into fill-missing-chunks
williamsnell 130a91b
Merge branch 'main' into fill-missing-chunks
d-v-b 89df859
Merge branch 'main' into fill-missing-chunks
d-v-b 404e4ac
Merge branch 'main' into fill-missing-chunks
d-v-b 093c7f4
Pass chunk indexes up
maxrjones 4d8cfe7
Merge branch 'main' into fill-missing-chunks
williamsnell 45a68e6
fill_missing_chunks -> read_missing_chunks
williamsnell c578231
Resolve behavioural differences between main and maxrjones@37a40e3.
williamsnell f01b049
Merge branch 'main' into fill-missing-chunks
williamsnell 4d7d0d2
Merge branch 'main' into fill-missing-chunks
williamsnell b9e4206
Merge branch 'main' into fill-missing-chunks
williamsnell 620a1ff
Merge branch 'main' into fill-missing-chunks
williamsnell d9bfe98
Merge branch 'main' into fill-missing-chunks
williamsnell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Added `array.fill_missing_chunks` configuration option. When set to `False`, reading missing chunks raises a `MissingChunkError` instead of filling them with the array's fill value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunate that chunk spec is implemented as something called
ArraySpecbecause that would be nice for handing over thechunk_coordsifArraySpeccould take in a coordinate arg but of course that doesn't make sense semantically