Merged
Conversation
Contributor
|
numpy 2.2 changes the string repr for arrays (shape info is now displayed), maybe that's the culprit? |
Contributor
Author
|
From memory that's exactly it |
Contributor
|
If you have the env, then running |
Contributor
Author
|
Ah amazing, thanks for sharing! https://github.com/scientific-python/pytest-doctestplus does a similar thing, but I'll checkout pytest-accept too |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## support/v2 #2552 +/- ##
===========================================
Coverage 99.95% 99.95%
===========================================
Files 38 38
Lines 14664 14666 +2
===========================================
+ Hits 14658 14660 +2
Misses 6 6
🚀 New features to boost your workflow:
|
dcherian
approved these changes
Dec 12, 2024
d-v-b
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I pinned numpy in a previous PR because it was breaking tests 😭 . This un-pins it to see what's going wrong, and then hopefully fix it.