Fix doc version in stable doc build#2543
Merged
dstansby merged 2 commits intozarr-developers:support/v2from Dec 12, 2024
Merged
Fix doc version in stable doc build#2543dstansby merged 2 commits intozarr-developers:support/v2from
dstansby merged 2 commits intozarr-developers:support/v2from
Conversation
joshmoore
approved these changes
Dec 11, 2024
Member
joshmoore
left a comment
joshmoore
left a comment
There was a problem hiding this comment.
This PR shows Version: 2.18.4.dev19 but so do other PRs (e.g., https://zarr--2552.org.readthedocs.build/en/2552/, Version: 2.18.4.dev18)
That being said, the code changes look sane. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #2016, by fetching tags during the readthedocs build. Fix taken from https://github.com/sunpy/sunpy/blob/8c35f7e0fdf46d77faaaa34a1a47e440332326dc/.readthedocs.yaml#L7C3-L9C38.
I also updated the setuptools_scm configuration to match their current docs, just to be safe.