Closes: #399 - Migrate away from bitnami/elasticsearch - #445
Draft
mgruner wants to merge 5 commits into
Draft
Conversation
mgruner
marked this pull request as draft
June 29, 2026 12:27
Collaborator
Author
|
@monotek this is mostly a suggestion from Claude. Could you have a first look to see if this goes in the right direction? I need to do some manual testing. |
There was a problem hiding this comment.
Pull request overview
Migrates the Zammad Helm chart’s bundled Elasticsearch deployment from the Bitnami subchart to Elastic’s official ECK-based eck-elasticsearch chart, updating chart wiring, documentation, and CI to reflect the new operator-managed setup.
Changes:
- Replaced the
bitnami/elasticsearchdependency withelastic/eck-elasticsearch(breaking change; requires ECK operator + CRDs). - Updated Helm templates/helpers to derive Elasticsearch host/user/secret references for the ECK-managed service/credentials.
- Updated README upgrade notes and CI validation to install the operator and validate CRD-backed manifests.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
zammad/values.yaml |
Replaced Bitnami Elasticsearch values with ECK Elasticsearch CR values and updated Elasticsearch config defaults/comments. |
zammad/templates/job-init.yaml |
Adjusted init job to source Elasticsearch password via helper-based secret key selection. |
zammad/templates/configmap-init.yaml |
Switched Elasticsearch URL/user composition to helper-based host/user resolution. |
zammad/templates/_helpers.tpl |
Added helpers for ECK host/user/secret name/key resolution used across templates. |
zammad/README.md |
Documented new ECK operator prerequisite and added upgrade notes for 16.x → 17.0.0. |
zammad/ci/full-values.yaml |
Removed now-irrelevant “existingSecret” config for bundled Elasticsearch in CI values. |
zammad/Chart.yaml |
Swapped chart dependency to eck-elasticsearch (aliased as elasticsearch) and bumped chart version to 17.0.0. |
.github/workflows/ci.yaml |
Installs ECK operator in CI before rendering/testing the chart. |
.github/kubeconform.sh |
Added CRD schema location to allow kubeconform validation of CRD-based kinds (ECK resources). |
.github/ct.yaml |
Added Elastic chart repo for chart-testing. |
.editorconfig |
Added shell indentation rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+134
to
+136
| {{- if .Values.zammadConfig.elasticsearch.enabled -}} | ||
| {{ .Release.Name }}-elasticsearch-es-elastic-user | ||
| {{- else if .Values.secrets.elasticsearch.useExisting -}} |
mgruner
force-pushed
the
migrate-es-bitnami-to-eck-operator
branch
from
July 22, 2026 10:24
34fde4e to
646097f
Compare
monotek
reviewed
Aug 3, 2026
| # Elasticsearch resource) from the datree CRDs catalog. | ||
| helm template "${CHART_DIR}" | kubeconform --strict --verbose \ | ||
| --schema-location default \ | ||
| --schema-location 'https://raw.githubusercontent.com/datreeio/CRDs-catalog/main/{{.Group}}/{{.ResourceKind}}_{{.ResourceAPIVersion}}.json' \ |
Member
There was a problem hiding this comment.
We could also create the crd schema here by: https://github.com/yannh/kubeconform/blob/master/scripts/openapi2jsonschema.py
Or the newer: https://github.com/yannh/kubeconform/tree/master/openapi2jsonschema-go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue this PR fixes
Special notes for your reviewer
Checklist