fix: clean <answer> tags from model output in parse_action#281
Open
majiayu000 wants to merge 1 commit intozai-org:mainfrom
Open
fix: clean <answer> tags from model output in parse_action#281majiayu000 wants to merge 1 commit intozai-org:mainfrom
majiayu000 wants to merge 1 commit intozai-org:mainfrom
Conversation
Add explicit removal of <answer> and </answer> tags from model output before parsing. This uses replace() instead of slice indexing to handle cases where the model output format may vary. The model sometimes outputs responses wrapped in <answer> tags, which was causing action parsing to fail or produce malformed output. Fixes zai-org#258
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<answer>and</answer>tags from model outputreplace()instead of slice indexing for robust tag cleaningProblem
The model sometimes outputs responses wrapped in
<answer>tags:This causes action parsing to fail or produce malformed output.
Solution
Add
replace('<answer>', '')andreplace('</answer>', '')at the beginning of parse_action to clean up these tags before parsing.Fixes #258