feat(lazyload): drop Options API to support disabling __VUE_OPTIONS_API__ by Copilot#13786
feat(lazyload): drop Options API to support disabling __VUE_OPTIONS_API__ by Copilot#13786yoyo837 wants to merge 8 commits intoyouzan:mainfrom
Conversation
…sition API Co-authored-by: yoyo837 <6134547+yoyo837@users.noreply.github.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13786 +/- ##
==========================================
- Coverage 89.60% 89.38% -0.22%
==========================================
Files 257 257
Lines 7013 6689 -324
Branches 1736 1671 -65
==========================================
- Hits 6284 5979 -305
+ Misses 384 375 -9
+ Partials 345 335 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: yoyo837 <6134547+yoyo837@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
本 PR 将 lazyload 模块中剩余的 Options API 组件迁移到 Composition API,以便在编译时安全关闭 __VUE_OPTIONS_API__,提升与纯 Vue 3 构建配置的兼容性。
Changes:
- 将
LazyImage从 Options API 改为defineComponent + setup实现 - 将
LazyComponent从 Options API 改为defineComponent + setup实现
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/vant/src/lazyload/vue-lazyload/lazy-image.js | LazyImage 组件改为组合式 API,并以 lazyBox 适配 lazy manager 的 listener 接口 |
| packages/vant/src/lazyload/vue-lazyload/lazy-component.js | LazyComponent 组件改为组合式 API,并以 lazyBox 接入 lazy manager |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
将剩余使用选项式API的组件改为组合式API,以支持在编译时安全的关闭
__VUE_OPTIONS_API__