Open
Conversation
swipe add rtl mode
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13123 +/- ##
==========================================
- Coverage 93.81% 93.67% -0.14%
==========================================
Files 257 257
Lines 6999 7018 +19
Branches 1730 1742 +12
==========================================
+ Hits 6566 6574 +8
- Misses 377 386 +9
- Partials 56 58 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chenjiahan
reviewed
Sep 22, 2024
Member
chenjiahan
left a comment
There was a problem hiding this comment.
这个 PR 看起来会极大地影响 Swipe 组件的性能,因为涉及到大量的 isRtl() 调用,里面需要调用 getComputedStyle,会产生性能开销。
社区里 Swipe 组件一般都是怎么适配 RTL 的呢?感觉需要先做下调研
Author
对这里进行了优化,只在initialize中进行一次调用 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
新增了swipe在direction属性为rtl时的布局和交互
更好的支持阿拉伯语、波斯语等RTL语言场景