Skip to content

fix: include SettingPreset in Swift package#1609

Open
maikelvdh wants to merge 1 commit intoyonaskolb:masterfrom
maikelvdh:spm-settingpreset
Open

fix: include SettingPreset in Swift package#1609
maikelvdh wants to merge 1 commit intoyonaskolb:masterfrom
maikelvdh:spm-settingpreset

Conversation

@maikelvdh
Copy link
Copy Markdown

SPM is copying the symlink Sources/XcodeGenKit/SettingPresets -> ../../SettingPresets/ as-is into the bundle, creating a broken symlink effectively. Therefore turning the symlink directive around which should make it work for all supported approaches as Mint/Make seem to follow symlink by usage of cp -R.

@yonaskolb
Copy link
Copy Markdown
Owner

Which issue are you trying to solve? In what scenario is the current setup broken?

@maikelvdh
Copy link
Copy Markdown
Author

Which issue are you trying to solve? In what scenario is the current setup broken?

The issue is that the installed SPM package through usage of mise (ie. https://mise.jdx.dev/dev-tools/backends/spm.html) results incorrect the SettingPresets. Effectively mise is using following https://github.com/jdx/mise/blob/main/src/backend/spm.rs#L190 to build the package with Swift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants