Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a caching mechanism for the JSON viewer state to improve error handling and user experience. When a jq query fails or returns only null values, the viewer now displays the previous valid state instead of showing nothing or invalid data.
Changes:
- Added a
cached_statefield to store the previous valid JSON viewer state - Modified error handling to restore and display the cached state when queries fail
- Changed null-result handling to display cached state with a warning message instead of proceeding with null data
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Use `termcfg` to configure keybinds and styles
Use `promkit-widgets` v0.3.0
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Write output to stdout
Bump up promkit-widget version to v0.5.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105 Return the originally provided JSON when jq returns null or falls
Fixes #100 (Above)
Fixes #101 Line wrapping
Fixes #7 (If it means mouse support)
Fixes #40 Write the output to stdout (from #108, UNIX only)