test(batch10-stage0): window-mixin composition guardrails#81
Conversation
…ion change) Stage 0 of the ExtrapolationWindow decomposition plan: pure characterization tests that make any future mixin split provably behavior-preserving. Encodes the failure modes the two-model plan review (Codex + Antigravity/Gemini) identified: 1. MRO frozen — a base re-order (or a shim forgetting its sub-mixins) silently changes method precedence. 2. Qt bases precede all mixins — documents the severance ordering. 3. No mixin overrides a Qt event handler — QMainWindow's C++ wrapper doesn't cooperatively super(), so such an override is silently unreachable (Gemini). 4. No unexpected duplicate method names across sibling mixins — splitting a monolith reverses left-to-right shadowing precedence; only the known intentional shim override (_on_fit_finished) is allowlisted (Codex+Gemini). 5. No __init__ in mixins — construction stays driven by the window (Codex). 6. Internals imported directly by tests (_statistics_raw_table_preserving_cells) stay importable — a split must re-export moved internals (Codex). Each behavioral guard is RED-proven (injecting a Qt-event override / duplicate name / mixin __init__ makes its test fail). 70 neighborhood tests pass; ruff clean. No production code touched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 24 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Batch 10 — Stage 0: window-mixin composition guardrails (tests only)
The first, lowest-risk stage of the
ExtrapolationWindowdecomposition plan(
docs/BATCH10_WINDOW_DECOMPOSITION_PLAN.md). No production code changes —pure characterization tests that make any future mixin split provably
behavior-preserving. Every check encodes a failure mode surfaced by the
two-model plan review (Codex/gpt-5.5 + Antigravity/Gemini) and re-verified
against the code.
tests/test_window_mixin_composition_guardrails.py:changes method precedence.
QMainWindow's C++ wrapper doesnot cooperatively
super(), so acloseEvent/resizeEvent/… override in amixin is silently unreachable (Gemini).
monolith reverses left-to-right shadowing precedence; only the known
intentional shim override (
_on_fit_finished) is allowlisted (Codex+Gemini).__init__in mixins — construction stays driven by the window (Codex).internals like
_statistics_raw_table_preserving_cells(Codex).Test plan
duplicate name / mixin
__init__makes its test fail).ruffclean; 70 neighborhood tests pass; no production code touched.Stages 1/3 (the actual splits) are separate future PRs, gated by these
guardrails. Stage 2 (cross-family run controller) and Stage 4 (Protocol) are
NO-GO per the review.
🤖 Generated with Claude Code