Skip to content

Psalm level 1#315

Merged
samdark merged 11 commits into
masterfrom
psalm1
Jul 1, 2026
Merged

Psalm level 1#315
samdark merged 11 commits into
masterfrom
psalm1

Conversation

@vjik

@vjik vjik commented Jun 30, 2026

Copy link
Copy Markdown
Member
Q A
Is bugfix?
New feature?
Breaks BC?
Tests pass? ✔️

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (cb52b32) to head (1b8cf0d).

Files with missing lines Patch % Lines
src/Debug/QueueCollector.php 0.00% 10 Missing ⚠️
src/Command/ListenCommand.php 0.00% 3 Missing ⚠️
src/Middleware/Consume/ConsumeMiddlewareStack.php 0.00% 3 Missing ⚠️
...dleware/FailureHandling/FailureMiddlewareStack.php 0.00% 3 Missing ⚠️
src/Middleware/Push/PushMiddlewareStack.php 0.00% 3 Missing ⚠️
src/Message/Serializer/MessageSerializer.php 0.00% 2 Missing ⚠️
src/Middleware/MiddlewareFactory.php 0.00% 2 Missing ⚠️
src/Message/GenericMessage.php 0.00% 1 Missing ⚠️
...iddleware/InvalidMiddlewareDefinitionException.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             master    #315   +/-   ##
========================================
  Coverage      0.00%   0.00%           
+ Complexity      334     329    -5     
========================================
  Files            51      51           
  Lines           918     923    +5     
========================================
- Misses          918     923    +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik requested a review from a team June 30, 2026 14:18
@vjik vjik added the status:code review The pull request needs review. label Jun 30, 2026
use CollectorTrait;

/**
* @var array[]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it obvious that it is an array?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's array of arrays, not just array.

private array $statuses = [];

/**
* @var array[]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it obvious that it is an array?

@vjik vjik requested a review from samdark June 30, 2026 17:27
@samdark samdark merged commit ccc4368 into master Jul 1, 2026
29 checks passed
@samdark samdark deleted the psalm1 branch July 1, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants