Open
Conversation
alcueca
suggested changes
Jan 25, 2023
Contributor
alcueca
left a comment
alcueca
left a comment
There was a problem hiding this comment.
The math can be made clearer, and casting fixed. A test harness is also a good idea at this point.
| @@ -0,0 +1,59 @@ | |||
| // SPDX-License-Identifier: BUSL-1.1 | |||
Contributor
There was a problem hiding this comment.
Please deploy on a fork, and use that to code a test harness that verifies that the ZenBullPrice obtained is within an order of magnitude of something. If ZenBull is expected to stay within 0.1 ETH and 10 ETH most of the time, that would be a good range to test against.
- remapping overridden for forge to make it compatible in env directory - upgraded npm pacakge version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note that there is a difference of 4 wei in the value quoted by the oracle as compared to the calculation provided by the opyn team.