fix: emit clear error for miscapitalized HTML attribute names#3998
Open
Madoshakalaka wants to merge 1 commit intomasterfrom
Open
fix: emit clear error for miscapitalized HTML attribute names#3998Madoshakalaka wants to merge 1 commit intomasterfrom
Madoshakalaka wants to merge 1 commit intomasterfrom
Conversation
When an attribute like `onSubmit` doesn't exactly match a known listener/boolean/special prop but matches case-insensitively, emit "Did you mean `onsubmit`?" instead of a cryptic IntoPropValue trait bound error. Closes #3996
|
Visit the preview URL for this PR (updated for commit d0eb878): https://yew-rs-api--pr3998-fix-case-insensitive-3fobzaue.web.app (expires Sun, 01 Mar 2026 06:19:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When an attribute like
onSubmitdoesn't exactly match a known listener/boolean/special prop but matches case-insensitively, emit "Did you meanonsubmit?" instead of a cryptic IntoPropValue trait bound error.Fixes #3996
Checklist