Add manual AI review tiers#671
Draft
MauroToscano wants to merge 13 commits into
Draft
Conversation
Contributor
Author
|
/ai-review standard |
MauroToscano
added
the
ai-review-standard
AI Review (standard)PR #671 · 17 changed files FindingsNo non-rejected structured findings were reported. Reviewer Lanes
Raw lane outputs, candidates, final issues, and model metrics are uploaded as workflow artifacts. |
MauroToscano
added
ai-review-standard
MauroToscano
added
ai-review-standard
MauroToscano
force-pushed
the
feat/manual-ai-review-tiers
branch
from
1b27986 to
52633cb
Compare
MauroToscano
added
ai-review-standard
MauroToscano
added
ai-review-standard
response_format={type: json_object} was added in the hardening commit and
turned out to be the cause of empty model responses: it routes to
structured-output providers and makes reasoning models (minimax-m3, glm,
mimo) reason until truncated at max_tokens without ever emitting content
(observed reasoning_tokens=33989, completion_tokens=32000, findings=0).
Make response_format opt-in per lane and rely on the existing extract_json
parser, matching the request shape that works locally. Also capture
finish_reason in the lane result so truncation is visible in the report.
MauroToscano
added
ai-review-standard
Without forced JSON mode the model occasionally emits invalid JSON (e.g. unescaped quotes when a finding quotes code), which strict json.loads rejects all-or-nothing, dropping a whole review to zero findings. Add an optional json-repair fallback in extract_json: try strict parsing first, and only on failure fall back to repair, flagging it as a parse warning so invalid output stays visible. Install json-repair in the review/verifier lane steps. Verified against real lane output: recovers all 6 findings that strict parsing dropped.
MauroToscano
removed
the
ai-review-standard
MauroToscano
added
the
ai-review-standard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Note: actionlint is not installed in this workspace.