Set %yast_icondir to /usr/share/icons/hicolor (bsc#1186066)

[lslezak]

• See https://bugzilla.suse.com/show_bug.cgi?id=1186066
• The YaST packages should not own the /usr/share/icons/ directory
• That is owned by the filesystem package but with different permissions and that causes troubles
• The hicolor subdirectory is owned by hicolor-icon-theme so it is not the ideal solution (it just moves the problem
  one level down), but as that directory is owned by more than 230 other packages changing that would require a lot of work...
• All YaST packages have icons only in the hicolor subdir so it should not cause problems
• The solution has been discussed with @DimStar77 on IRC

[dirkmueller]

I wonder - as that really just tosses the can down the road - if it would be acceptable to remove uses of yast_icondir inside the yast modules? it should be a one time effort, but it will be a permanent fix. Please note that unless yast_metainfodir and yast_fillupdir is removed everywhere, it will still conflict with the filesystem update under discussion. so this is a partial,albeit very smart fix.

[dirkmueller]

see e.g. yast/yast-bootloader#642 - its not that much of a work

[lslezak]

Thanks for an example. Yes, a full fix is better, but that will require touching many YaST packages (my quick grep found yast_icondir in 79 spec files)... But in the end that might save some time later.

[dgdavid]

But in the end that might save some time later.

So, are we gonna merge this by now and postpone the full-fix or can we close this PR in favor of touching the 79 spec files?

BTW, is yast/yast-installation#958 somehow related to this?

[embar-]

Forcing %yast_icondir to /usr/share/icons/hicolor could be reasonable if we have only Hicolor icon theme for YaST.
However you can find another full themes of YaST icons that are supported:
E.g. Oxygen theme from yast2-theme-oxygen has /usr/share/icons/oxygen path;
Breeze theme from yast2-theme-breeze has /usr/share/icons/breeze and /usr/share/icons/breeze-dark paths.

See also https://software.opensuse.org/search?q=yast2-theme

Thus I vote against this pull request (forcing directory to hicolor).

[embar-]

Also update-alternatives is not option, because we can install yast2-theme-breeze and yast2-theme-oxygen (or other themes) simultaneously and actual theme depends on desktop icon theme of (root) user - it is used automatically.
See also already fixed bugs: 1159283, 1130293