Closed
Conversation
Contributor
|
@sdzyba Thanks for highlighting this, and the PR. |
Contributor
|
One thing I wanted to mention --
|
Author
|
@abhinav @prashantv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
github.com/yarpc/yabcannot be imported as Go module dependency due to an error while trying to executego get github.com/yarpc/yab:In order to fix that the necessary to upgrade dependencies were upgraded, particularly:
go.uber.org/atomicgithub.com/opentracing/opentracing-gogithub.com/uber/tchannel-goAnd some related modules as well.
Also tried to keep
glide.yamldeclarations in sync with what declared in thego.mod.There is also an issue with
github.com/streadway/quantile(which is required as an indirect dependency) and Go 1.18.The corresponding merge request is not merged yet so I had to
replacethe issue in thego.mod.