Skip to content

Surface the 20 MB CSV upload cap in the upload UI #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvanhorn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Surface the 20 MB CSV upload cap in the upload UI #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions frontend/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,9 @@ <h5 class="modal-title d-flex align-items-center gap-2">
</div>
</div>
<input type="file" class="form-control form-control-sm" id="fileInput" accept=".csv">
<div class="form-text small mt-1">
<i class="bi bi-info-circle"></i> Max 20 MB &middot; runs in your browser
</div>
<div id="uploadPreview" class="mt-2" style="display: none;">
<small class="text-muted">Preview:</small>
<div class="table-responsive" style="max-height: 150px;">
Expand Down
2 changes: 1 addition & 1 deletion frontend/js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ async function uploadFile() {
try {
const file = fileInput.files[0];
if (file.size > 20 * 1024 * 1024) {
throw new Error('File exceeds 20 MB cap — Pyodide runs out of memory on large CSVs.');
throw new Error('File is too large for the browser runtime — please subsample first (max 20 MB).');
}
const buf = new Uint8Array(await file.arrayBuffer());
const data = await pyCallBinary('upload_csv', buf, [file.name]);
Expand Down