Update cli.py - #313
Closed
evanjain-dot wants to merge 1 commit into
Closed
Conversation
Contributor
|
@evanjain-dot is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@yakew7 - new PR touching a path you own, please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add proxy extra to CI, stop hardcoding --min-group-size's default
audits.yml's profiler job never installed the proxy extra, so
tests/test_proxy.py's scipy-gated tests were silently skipped in CI
(closes #298) - verified locally that they actually run once scipy
is present.
--min-group-size hardcoded default=100 in argparse instead of
deferring to profiler.MIN_GROUP_SIZE like every sibling threshold
flag already does, so a future tune of that constant would silently
not reach the CLI (closes #299 ). Confirmed the resolved default is
still 100 via _resolve_opts's fallback.