Skip to content

fix: drop hardcoded default for --min-group-size CLI flag - #312

Merged
yakew7 merged 2 commits into
yakew7:mainfrom
VedantMadane:fix/issue-299
Aug 24, 2026
Merged

fix: drop hardcoded default for --min-group-size CLI flag#312
yakew7 merged 2 commits into
yakew7:mainfrom
VedantMadane:fix/issue-299

Conversation

@VedantMadane

Copy link
Copy Markdown
Contributor

Summary

fix: drop hardcoded default for --min-group-size CLI flag

Changes

  • Declare --min-group-size without default=100 so _resolve_opts can use profiler.MIN_GROUP_SIZE.
  • Matches how the other threshold flags already work for profile and compare.

Fixes #299

- Declare --min-group-size without default=100 so _resolve_opts can use profiler.MIN_GROUP_SIZE.
- Matches how the other threshold flags already work for profile and compare.

Fixes yakew7#299

Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
@VedantMadane
VedantMadane requested a review from yakew7 as a code owner August 24, 2026 16:55
@vercel

vercel Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

@VedantMadane is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown

Hey @VedantMadane, your first PR on Fair Code, that's awesome, thank you.

This project is about making AI more accountable, and contributions like yours are what keep that work going. We'll review your changes shortly.

If you haven't already, give the contributing guide a quick read: it covers how audits are structured and what we look for in a review.

@github-actions

Copy link
Copy Markdown

@yakew7 - new PR touching a path you own, please review.

@yakew7

yakew7 commented Aug 24, 2026

Copy link
Copy Markdown
Owner

Hey @ahmdkaml could you just review this?

meanwhile hey @VedantMadane! I'm yash the owner of this repo and i just wanna say thank you for the pr if u like this repo pls give it a star it helps other find this repo out asw and it helps me out also. If you're interested in the repo further prs are always appreciated

@yakew7 yakew7 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edits seem fine and proper asw!

@yakew7
yakew7 merged commit b4173dc into yakew7:main Aug 24, 2026
16 of 17 checks passed
yakew7 added a commit that referenced this pull request Aug 25, 2026
Credits AnayDhawan (#294, closing #283/#272), Shreyash0712's
follow-up (#295), new contributor VedantMadane (#312, closing #299),
propcgamer20-png (#311, closing #298), and ahmdkaml (#288, closing
#270 - manually closed since the PR never referenced the issue).
Reordered the Contributors section for AnayDhawan's new PR-count
tier. Added the 2026-W35 metrics snapshot: stars 43->47, forks
22->23, contributors 17->18 (live GitHub numbers plus VedantMadane's
first merged PR), synced across ROADMAP.md and README.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

faircode/cli.py's --min-group-size hardcodes default=100 instead of deferring to profiler.MIN_GROUP_SIZE

3 participants