Skip to content

fix: JSON parsing with trailing commas enabled #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yCodeTech merged 2 commits into from
Jul 20, 2026
Merged

fix: JSON parsing with trailing commas enabled #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8564517
fix: JSON parsing with trailing commas enabled in `readJsonFile`.
yCodeTech Jul 20, 2026
826a76e
refactor: JSON parse error message formatting.
yCodeTech Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ export function readJsonFile<T extends JsonValue = JsonObject>(filepath: string,
.toString()
.replace(/^\uFEFF/, ""); // Remove BOM if present.

const jsonContents = jsonc.parse(fileContent, jsonErrors, {allowEmptyContent: true}) ?? {};
// Parse the JSON content using jsonc-parser, allowing empty content and trailing commas.
const jsonContents = jsonc.parse(fileContent, jsonErrors, {allowEmptyContent: true, allowTrailingComma: true}) ?? {};

if (jsonErrors.length > 0) {
const errorMessages = constructJsonParseErrorMsg(filepath, fileContent, jsonErrors);
Expand Down Expand Up @@ -78,19 +79,18 @@ function constructJsonParseErrorMsg(filepath: string, fileContent: string, jsonE
return jsonErrors
.map((err, i) => {
// Get the error name from the numeric error code.
// The name is PascalCased, so we need to format it by adding spaces
const errorName = jsonc.printParseErrorCode(err.error);

// The error name is PascalCased, so we need to format it by adding spaces
// before capital letters for readability.
const errorName = jsonc
.printParseErrorCode(err.error)
.replace(/([A-Z])/g, " $1")
.trim();
const errorNameFormatted = errorName.replace(/([A-Z])/g, " $1").trim();

// Calculate line and column numbers from the error offset.
const lineNumber = fileContent.substring(0, err.offset).split("\n").length;
const columnNumber = err.offset - fileContent.lastIndexOf("\n", err.offset - 1);

// Return the formatted error message.
return `\tError ${i + 1} - ${errorName} at "${filepath}:${lineNumber}:${columnNumber}"\n`;
return `\tError ${i + 1} [${errorName}] - ${errorNameFormatted} at "${filepath}:${lineNumber}:${columnNumber}"\n`;
})
.join("\n");
}
Expand Down
Loading