Skip to content

Fix release publish workflow robustness #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xscriptor merged 1 commit into from
Apr 26, 2026
Merged

Fix release publish workflow robustness #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 23 additions & 15 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ permissions:
env:
CARGO_TERM_COLOR: always
RELEASE_TAG: ${{ github.event_name == 'workflow_dispatch' && inputs.release_tag || github.ref_name }}
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"

jobs:
# ── Ubuntu → .deb ──────────────────────────────────────────────────────────
Expand All @@ -25,7 +26,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
- name: Install cargo-deb
run: cargo install cargo-deb --locked
- name: Build
Expand All @@ -38,7 +39,7 @@ jobs:
cp target/debian/gitnapse_${VERSION}_amd64.deb "${asset}"
echo "ASSET=${asset}" >> "$GITHUB_ENV"
- name: Upload artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: asset-linux-ubuntu
path: ${{ env.ASSET }}
Expand All @@ -59,7 +60,7 @@ jobs:
curl https://sh.rustup.rs -sSf | sh -s -- -y --profile minimal
echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
- name: Install cargo-generate-rpm
run: cargo install cargo-generate-rpm --locked
- name: Build
Expand All @@ -72,7 +73,7 @@ jobs:
cp target/generate-rpm/gitnapse-${VERSION}-1.x86_64.rpm "${asset}"
echo "ASSET=${asset}" >> "$GITHUB_ENV"
- name: Upload artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: asset-linux-fedora
path: ${{ env.ASSET }}
Expand All @@ -93,7 +94,7 @@ jobs:
curl https://sh.rustup.rs -sSf | sh -s -- -y --profile minimal
echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
- name: Build
run: cargo build --release --locked
- name: Package (.pkg.tar.zst)
Expand All @@ -116,7 +117,7 @@ EOF
bsdtar --zstd -cf "${asset}" -C "${PKGDIR}" .
echo "ASSET=${asset}" >> "$GITHUB_ENV"
- name: Upload artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: asset-linux-arch
path: ${{ env.ASSET }}
Expand All @@ -129,7 +130,7 @@ EOF
runs-on: windows-latest
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
- name: Build
run: cargo build --release --locked
- name: Package (.exe)
Expand All @@ -139,7 +140,7 @@ EOF
Copy-Item -Path "target/release/gitnapse.exe" -Destination $asset
"ASSET=$asset" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
- name: Upload artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: asset-windows
path: ${{ env.ASSET }}
Expand All @@ -152,7 +153,7 @@ EOF
runs-on: macos-latest
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
- name: Build
run: cargo build --release --locked
- name: Package (.dmg)
Expand All @@ -170,7 +171,7 @@ EOF
"${asset}"
echo "ASSET=${asset}" >> "$GITHUB_ENV"
- name: Upload artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: asset-macos
path: ${{ env.ASSET }}
Expand All @@ -192,9 +193,9 @@ EOF
id-token: write
steps:
- name: Checkout repository metadata
uses: actions/checkout@v4
uses: actions/checkout@v5
- name: Download build artifacts
uses: actions/download-artifact@v4
uses: actions/download-artifact@v5
with:
pattern: asset-*
path: dist
Expand All @@ -206,6 +207,13 @@ EOF
app-id: ${{ secrets.RELEASE_GH_APP_ID }}
private-key: ${{ secrets.RELEASE_GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
- name: Validate required release auth
shell: bash
run: |
if [ -z "${{ steps.app_token.outputs.token }}" ]; then
echo "Missing GitHub App token. Verify RELEASE_GH_APP_ID/RELEASE_GH_APP_PRIVATE_KEY and App installation permissions."
exit 1
fi
- name: Show assets
run: ls -lah dist
- name: Install cosign
Expand All @@ -222,6 +230,6 @@ EOF
GH_TOKEN: ${{ steps.app_token.outputs.token }}
GH_REPO: ${{ github.repository }}
run: |
gh release view "${RELEASE_TAG}" >/dev/null 2>&1 || \
gh release create "${RELEASE_TAG}" --title "${RELEASE_TAG}" --generate-notes
gh release upload "${RELEASE_TAG}" dist/* --clobber
gh release view "${RELEASE_TAG}" --repo "${GH_REPO}" >/dev/null 2>&1 || \
gh release create "${RELEASE_TAG}" --repo "${GH_REPO}" --title "${RELEASE_TAG}" --generate-notes
gh release upload "${RELEASE_TAG}" dist/* --repo "${GH_REPO}" --clobber