Skip to content

Conversation

@thekid
Copy link
Member

@thekid thekid commented Jan 6, 2026

Currently, this is an example of the output:

[11:14:09 20212 debug] >>> [
  jsonrpc => "2.0"
  id => 8
  method => "tools/call"
  params => [
    _meta => [
      progressToken => 42
]
    name => "greeting_send"
    arguments => [
      address => "thekid@internet"
]
]
]

The closing braces are completely unaligned!


This is the way it looks with this patch:

[11:14:09 20212 debug] >>> [
  jsonrpc => "2.0"
  id => 5
  method => "tools/call"
  params => [
    _meta => [
      progressToken => 42
    ]
    name => "greeting_send"
    arguments => [
      address => "thekid@internet"
    ]
  ]
]

@thekid
Copy link
Member Author

thekid commented Jan 6, 2026

This is technically a BC break, as people may have been relying on this pattern when parsing logfiles. Here's the dependencies of this library, if we play it hard, it would mean a major release for all of them.

$ grep xp-framework/logging ../*/composer.json | sed -E 's#^../([^/]+)/composer.json#\1#g'
ftp:    "xp-framework/logging": "^11.0 | ^10.0 | ^9.1",
handlebars:    "xp-framework/logging": "^11.0 | ^10.0",
http:    "xp-framework/logging": "^11.0 | ^10.0 | ^9.0 | ^8.0 | ^7.0 | ^6.5",
logging:  "name" : "xp-framework/logging",
mail:    "xp-framework/logging": "^11.0 | ^10.0 | ^9.0 | ^8.0 | ^7.0",
networking:    "xp-framework/logging": "^11.0 | ^10.0 | ^9.0 | ^8.0 | ^7.0",
openai:    "xp-framework/logging": "^11.2",
rdbms:    "xp-framework/logging": "^11.0 | ^10.0 | ^9.0 | ^8.0 | ^7.0",
rest-client:    "xp-framework/logging": "^11.0 | ^10.0",
stomp:    "xp-framework/logging": "^11.0 | ^10.0 | ^9.1",
websockets:    "xp-framework/logging": "^11.0 | ^10.0 | ^9.1",

I'll go with a feature release instead.

@thekid thekid merged commit b3d78b4 into master Jan 6, 2026
24 checks passed
@thekid thekid deleted the refactor/indentation branch January 6, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants