Add Python typing capability to the library.#15
Open
AbstractUmbra wants to merge 10 commits intoxivapi:masterfrom
Open
Add Python typing capability to the library.#15AbstractUmbra wants to merge 10 commits intoxivapi:masterfrom
AbstractUmbra wants to merge 10 commits intoxivapi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Thank you for creating this library, it is great and easy to use.
I have created this PR which achieves the following, in no particular order:-
__all__specification and class__slots__.masterto check the types and functionality of the codebase from Python 3.7 -> 3.11.I didn't want to edit functionality of the codebase for now, but in a future PR I may add a more object-style usage to the return types of the client methods, or at the very least ensure the payload types are known.