Skip to content

Avoid DataArray construction when scanning for cell_measures #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcherian merged 1 commit into from
Jun 12, 2026
+6 −9
Merged

Avoid DataArray construction when scanning for cell_measures #647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions cf_xarray/accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2107,17 +2107,14 @@ def cell_measures(self) -> dict[str, list[Hashable]]:
"""

obj = self._obj
if isinstance(obj, DataArray):
variables = [*obj.coords.variables.values(), obj.variable]
else:
variables = list(obj.variables.values())
all_attrs = [
ChainMap(da.attrs, da.encoding).get("cell_measures", "")
for da in obj.coords.values()
ChainMap(var.attrs, var.encoding).get("cell_measures", "")
for var in variables
]
if isinstance(obj, DataArray):
all_attrs += [ChainMap(obj.attrs, obj.encoding).get("cell_measures", "")]
elif isinstance(obj, Dataset):
all_attrs += [
ChainMap(da.attrs, da.encoding).get("cell_measures", "")
for da in obj.data_vars.values()
]
as_dataset = self._maybe_to_dataset().reset_coords()

keys: dict[str, str] = {}
Expand Down
Loading