quicktest: add -with-tag and -without-tag suite filters - #7227
Open
gthvn1 wants to merge 1 commit into
Open
Conversation
last-genius
requested changes
Aug 17, 2026
last-genius
reviewed
Aug 17, 2026
gthvn1
force-pushed
the
gtn-split-quicktest
branch
from
August 17, 2026 16:52
6c836f8 to
ae594ca
Compare
last-genius
approved these changes
Aug 18, 2026
gthvn1
force-pushed
the
gtn-split-quicktest
branch
from
August 18, 2026 11:19
ae594ca to
b6eda6a
Compare
changlei-li
reviewed
Aug 19, 2026
Storage CI runs quicktest once per SR under test, but not every suite acutally depends on the SR passed via -sr. Suites like message, xenstore, event etc. exercise xapi behavior that has nothing to do with storage and produce the same result no matter which SR is passed. Today they still re-run in full for every SR. This patch tags every suite in quicktest.ml with a `tag list` (currently only `Sr` exists) and adds two new flags, -with-tag and -without-tag, to select suites by tag. A suite with no tags is common to every SR. Both flags are repeatable and can be freely combined with each other and with -run-only for finer grained selection. -list-tests also respects them. -list-tests also respect them, so `quicktest -list-tests -with-tag sr` shows exactly what a real -with-tag sr run would execute. Using a tag list rather than a closed variant keeps the door open for other axes to filter later (e.g. slow-running suites). Signed-off-by: Guillaume Thouvenin <guillaume.thouvenin@vates.tech>
gthvn1
force-pushed
the
gtn-split-quicktest
branch
from
August 20, 2026 08:05
b6eda6a to
f0b54f8
Compare
gthvn1
changed the title
changlei-li
approved these changes
Aug 20, 2026
changlei-li
left a comment
changlei-li
left a comment
Member
There was a problem hiding this comment.
Please update the PR message as well.
Have you tested this?
last-genius
approved these changes
Aug 20, 2026
Contributor
Author
What I have tested is a "backport" on lcm (it conflicts so it is not just a cherry-pick) because the version of xcp-ng I'm using (8.3) is based on lcm. Maybe I can try to built our master and just copy it for testing. The quicktestbin should work even if version are not the same. I will check that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storage CI runs quicktest once per SR under test, but not every suite acutally
depends on the SR passed via -sr. Suites like message, xenstore, event etc.
exercise xapi behavior that has nothing to do with storage and produce the same
result no matter which SR is passed. Today they still re-run in full for every
SR.
This patch tags every suite in quicktest.ml with a
tag list(currently onlySrexists) and adds two new flags, -with-tag and -without-tag, to selectsuites by tag. A suite with no tags is common to every SR. Both flags are
repeatable and can be freely combined with each other and with -run-only for
finer grained selection. -list-tests also respects them. -list-tests also
respect them, so
quicktest -list-tests -with-tag srshows exactly what a real-with-tag sr run would execute.
Using a tag list rather than a closed variant keeps the door open for other
axes to filter later (e.g. slow-running suites).