Fix Firefox font loading detection in tests #406
Conversation
Replaced `Array.from(document.fonts.values())` with `Array.from(document.fonts)` to correctly iterate over loaded fonts in Firefox. Removed the conditional logic that skipped the assertion in Firefox, enabling strict checks on all browsers. Co-authored-by: xRahul <1639945+xRahul@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Fixed a flaky test in
tests/font-performance.spec.tswheredocument.fonts.values()was returning an empty iterator in Firefox despite the font being loaded.Switched to iterating
document.fontsdirectly, which consistently reports the loaded fonts.Removed the workaround that skipped the assertion in Firefox, ensuring the test now strictly verifies font loading behavior across all supported browsers (Chromium, Firefox, WebKit).
PR created automatically by Jules for task 4548239006413877363 started by @xRahul