[Feature] Added FMJ Entrypoint For Mod Settings Registry#838
Open
amiralimollaei wants to merge 2 commits into
Open
[Feature] Added FMJ Entrypoint For Mod Settings Registry#838amiralimollaei wants to merge 2 commits into
amiralimollaei wants to merge 2 commits into
Conversation
Author
|
I've migrated NEV's configuration to this VkModSettingsFactory to find potential bugs with the implementation and to provide an example: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a very simple API for other mods to implement and a custom entrypoint that other mods can add to their
fabric.mod.jsonthat allows for them to register their own configuration pages to theModSettingsRegistrywithout having a hard dependency on VulkanMod, here is an example:VkModSettingsFactory:VkModSettingsFactoryImplto the fabric.mod.json:it will be loaded and added to the mod registry automatically (when VulkanMod exists) and will not do anything when VulkanMod is not present, allowing other mods to register their own
ModSettingsEntrywithout having a hard dependency on VulkanMod.