Adding sdk changes for header appending functionality#2189
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe PR introduces Suggested Reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8a0ddb7 to
40d1d71
Compare
Dependency Validation ResultsDependency name: github.com/wso2/api-platform/sdk/core Next Steps
|
40d1d71 to
f3466f4
Compare
Dependency Validation ResultsDependency name: github.com/wso2/api-platform/sdk/core Next Steps
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@gateway/build-manifest.yaml`:
- Line 10: The manifest version update at Line 10 for api-key-auth to v1.0.4
appears inconsistent with the release objective. Review the intended scope of
this release to determine which components should be bumped, then ensure all
affected component versions in the manifest are updated consistently. If the
objective is to bump analytics-header-filter and jwt-auth, verify that these
components have their versions updated and that api-key-auth remains at its
current version, or if api-key-auth should indeed be bumped, confirm that
analytics-header-filter and jwt-auth are also updated to maintain the
name|version alignment contract required by the policy loader.
In `@gateway/gateway-runtime/policy-engine/go.mod`:
- Line 19: The go.sum file is out of sync with the go.mod file after bumping
github.com/wso2/api-platform/sdk/core from v0.2.14 to v0.2.15. The go.sum file
still contains only the v0.2.14 hashes but is missing entries for v0.2.15, which
is required since multiple files in the policy-engine depend on types from the
sdk/core package. Run `go mod tidy` in the gateway/gateway-runtime/policy-engine
directory to synchronize go.mod and go.sum, which will update the checksums to
match the v0.2.15 version requirement.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5c2c9db3-a918-4eab-8ba7-7eaf6dd2d76d
📒 Files selected for processing (5)
gateway/build-manifest.yamlgateway/gateway-runtime/policy-engine/go.modgateway/gateway-runtime/policy-engine/internal/kernel/translator.gogateway/gateway-runtime/policy-engine/internal/kernel/translator_test.gogateway/gateway-runtime/policy-engine/pkg/engine/types.go
f3466f4 to
44ddc92
Compare
Dependency Validation ResultsDependency name: github.com/wso2/api-platform/sdk/core Next Steps
|
Purpose
Adds the SDK and engine related modifications required for providing the header appending functionality