Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
There was a problem hiding this comment.
Pull request overview
This PR replaces the Mozart-based dependency prefixing approach with Strauss (downloaded as a phar) and updates how production dependencies are managed/prefixed, including cleaning up previously committed prefixed dependency sources and refreshing the bundled Action Scheduler.
Changes:
- Switch dependency prefixing from
coenjacobs/mozarttostrauss(phar), updating Composer config and scripts accordingly. - Remove previously committed prefixed dependency sources under
classes/Dependencies/andinc/classes/Dependencies/...and rely on prefixed vendor output. - Update bundled Action Scheduler to 3.9.3, including schema/index changes and new recurring-action support.
Reviewed changes
Copilot reviewed 71 out of 74 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
composer.json |
Removes Mozart, configures Strauss prefixing, and updates install/update scripts to run prefixing. |
phpstan.neon.dist |
Stops excluding the old classes/Dependencies/ path from analysis. |
inc/Dependencies/ActionScheduler/** |
Updates Action Scheduler to 3.9.3 and introduces new scheduling/DB-claiming changes. |
classes/Admin/PluginFamilySubscriber.php |
Expands delegated methods to match updated PluginFamily surface area after dependency changes. |
.github/workflows/*.yml |
Ensures Strauss is present and runs Composer with scripts so prefixing occurs in CI; updates test matrix/steps. |
.gitignore, .gitattributes, .distignore |
Adjust ignore/export rules for new tooling artifacts (e.g., bin/strauss.phar, lock files). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Replace Mozart by Strauss to handle prefixing the namespaces of our production dependencies
Type of change
Detailed scenario
What was tested
Tested global function of the plugin, as this mostly impacts the container (used everywhere), and the plugin family
How to test
Smoke tests should cover testing the PR
Affected Features & Quality Assurance Scope
Technical description
Documentation
Strauss is used as a phar file instead of a composer dev dependency.
The prefixed dependencies are preserved in the vendor folder, so they don't need to be part of the committed files anymore.
New dependencies
Removed
mozartand replace it withstraussas a phar, not a dependencyMandatory Checklist
Code validation
Code style