Skip to content

Fix HTTP URLs converted to HTTPS in core install #6229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 5 commits into from
Mar 20, 2026
Merged

Fix HTTP URLs converted to HTTPS in core install #6229

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d12ad28
Initial plan
Copilot Feb 4, 2026
baffd05
Fix HTTP to HTTPS conversion in wp core install --prompt
Copilot Feb 4, 2026
722f7b1
Improve test to validate regression with pre-existing HTTPS variable
Copilot Feb 4, 2026
8f0d4e7
Merge branch 'main' into copilot/fix-wp-core-install-url
swissspidy Mar 10, 2026
224cc13
Merge branch 'main' into copilot/fix-wp-core-install-url
swissspidy Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions features/class-wp-cli.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,21 @@ Feature: Various utilities for WP-CLI commands
| func |
| proc_open |
| proc_close |

Scenario: HTTP URL scheme does not set HTTPS server variable
Given an empty directory

When I run `wp --skip-wordpress eval 'WP_CLI::set_url("http://example.com"); echo isset($_SERVER["HTTPS"]) ? "set" : "not set";'`
Then STDOUT should be:
"""
not set
"""

Scenario: HTTPS URL scheme sets HTTPS server variable
Given an empty directory

When I run `wp --skip-wordpress eval 'WP_CLI::set_url("https://example.com"); echo isset($_SERVER["HTTPS"]) && $_SERVER["HTTPS"] === "on" ? "on" : "off";'`
Then STDOUT should be:
"""
on
"""
Comment thread
swissspidy marked this conversation as resolved.
Outdated
2 changes: 2 additions & 0 deletions php/class-wp-cli.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,8 @@ private static function set_url_params( $url_parts ) {
if ( isset( $url_parts['host'] ) ) {
if ( isset( $url_parts['scheme'] ) && 'https' === strtolower( $url_parts['scheme'] ) ) {
$_SERVER['HTTPS'] = 'on';
} else {
unset( $_SERVER['HTTPS'] );
}

$_SERVER['HTTP_HOST'] = $url_parts['host'];
Expand Down
Loading