Skip to content

Skip some tests on SQLite for now#220

Merged
swissspidy merged 1 commit intomainfrom
fix/skip-sqlite
Mar 18, 2026
Merged

Skip some tests on SQLite for now#220
swissspidy merged 1 commit intomainfrom
fix/skip-sqlite

Conversation

@swissspidy
Copy link
Member

See #190

@swissspidy swissspidy requested a review from a team as a code owner March 18, 2026 08:40
Copilot AI review requested due to automatic review settings March 18, 2026 08:40
@github-actions
Copy link
Contributor

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request temporarily disables several regex search/replace tests when the test suite is executed against an SQLite database. This action addresses an existing issue where these specific tests are failing or behaving unexpectedly in an SQLite environment, allowing the continuous integration pipeline to pass while the underlying problem is investigated and resolved.

Highlights

  • Test Skipping: Introduced @skip-sqlite tags to five regex search/replace scenarios in features/search-replace.feature.
  • Issue Reference: Added comments linking the skipped tests to issue SQLite Compatibility #190, indicating a known problem with these tests on SQLite.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the @skip-sqlite tag to five scenarios in features/search-replace.feature that are related to regex search and replace. This is done to temporarily disable these tests on SQLite, as they are currently failing. The changes are straightforward and correctly implemented. A comment linking to the corresponding issue is included for each skipped scenario, which is good practice. After reviewing the other regex-related scenarios, it appears the selection of tests to skip is accurate. No issues were found in this pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR temporarily skips a subset of Behat scenarios when running against SQLite to work around the SQLite compatibility problems tracked in #190 (syntax errors and CI hangs).

Changes:

  • Add @skip-sqlite tag annotations to several regex-related search-replace scenarios.
  • Add inline comments linking the skip decision to issue #190.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy merged commit a04ff12 into main Mar 18, 2026
68 checks passed
@swissspidy swissspidy deleted the fix/skip-sqlite branch March 18, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants