Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions features/plugin.feature
Original file line number Diff line number Diff line change
Expand Up @@ -1032,6 +1032,56 @@ Feature: Manage WordPress plugins
"""


@require-wp-4.0
Scenario: Do not report a WordPress requirement when the installed version already meets the update's requirement
Given a WP install
And a wp-content/plugins/example/example.php file:
"""
<?php
/**
* Plugin Name: Example Plugin
* Version: 1.0.0
* Requires at least: 3.7
* Tested up to: 6.7
"""
And that HTTP requests to https://api.wordpress.org/plugins/update-check/1.1/ will respond with:
"""
HTTP/1.1 200 OK

{
"plugins": [],
"translations": [],
"no_update": {
"example/example.php": {
"id": "w.org/plugins/example",
"slug": "example",
"plugin": "example/example.php",
"new_version": "2.0.0",

"requires": "4.0",
"requires_php": "5.6",
"requires_plugins": [],
"compatibility": []
}
}
}
"""

When I run `wp plugin list`
Then STDOUT should be a table containing rows:
| name | status | update | version | update_version | auto_update | requires | requires_php |
| example | inactive | unavailable | 1.0.0 | 2.0.0 | off | 4.0 | 5.6 |

When I try `wp plugin update example`
Then STDERR should contain:
"""
Warning: example: Update file not provided. Contact author for more details
"""
And STDERR should not contain:
"""
This update requires WordPress version
"""

@require-wp-4.0
Scenario: Show plugin update as unavailable if it doesn't meet PHP requirements
Given a WP install
Expand Down
2 changes: 1 addition & 1 deletion src/Plugin_Command.php
Original file line number Diff line number Diff line change
Expand Up @@ -1049,7 +1049,7 @@ protected function get_item_list() {
$items[ $file ]['requires'] = isset( $plugin_update_info->requires ) ? $plugin_update_info->requires : null;
$items[ $file ]['requires_php'] = isset( $plugin_update_info->requires_php ) ? $plugin_update_info->requires_php : null;

if ( isset( $plugin_update_info->requires ) && version_compare( $wp_version, $requires, '>=' ) ) {
if ( isset( $plugin_update_info->requires ) && version_compare( $wp_version, $plugin_update_info->requires, '<' ) ) {
$reason = "This update requires WordPress version $plugin_update_info->requires, but the version installed is $wp_version.";
} elseif ( ! isset( $plugin_update_info->package ) ) {
$reason = 'Update file not provided. Contact author for more details';
Comment on lines +1052 to 1055
Expand Down
Loading