fix: preserve verification_prefix in organization domain deserialization#1486
fix: preserve verification_prefix in organization domain deserialization#1486smorimoto wants to merge 1 commit intoworkos:mainfrom
Conversation
Greptile OverviewGreptile SummaryAdds the missing Changes made:
The implementation is consistent with existing patterns (matches Confidence Score: 5/5
Important Files Changed
Last reviewed commit: f986675 |
f986675 to
378ded6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e6c3598bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/organization-domains/serializers/organization-domain.serializer.ts
Outdated
Show resolved
Hide resolved
9e6c359 to
15199bd
Compare
The OrganizationDomain interface and deserializer were missing the verification_prefix field, which is present in the Events API response for organization_domain.* events and in nested domain data within organization.* events. Adds verification_prefix as an optional field to both OrganizationDomain and OrganizationDomainResponse, and conditionally spreads verificationPrefix only when the source field is present, matching the existing pattern used for verificationToken.
15199bd to
f11a56d
Compare
Summary
verification_prefixas an optional field toOrganizationDomainandOrganizationDomainResponseinterfacesverification_prefix→verificationPrefixindeserializeOrganizationDomainThe Events API documentation for
organization_domain.*events includes averification_prefixfield in the event data, but the deserialiser was silently dropping it.Test plan
npx tsc --noEmit)npm test)