chore: drop dead Your Profile menu items#62
Open
mjdavidson wants to merge 1 commit into
Open
Conversation
Per git history, every "Your Profile" link in this repo has had href: '#' since the dashboard page first appeared in 2021-07-20 (commit f30f116). The placeholder was never wired up and there's no profile view to point at — keeping decorative menu items that don't navigate is misleading on a public demo. Removed from: - components/Layout.tsx userNavigation (header dropdown + mobile) - components/Settings.tsx subNavigation (settings sidebar) UserCircleIcon import dropped along with it. Settings sidebar now has just Admin Settings. If a profile view is added in phase 3 (AuthKit), wire it up fresh with a real route.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per git history, every "Your Profile" link has had
href: '#'since the dashboard page first appeared in 2021-07-20. The placeholder was never wired up. Removed fromLayout.tsxuserNavigation andSettings.tsxsubNavigation;UserCircleIcondropped along with it. If AuthKit ends up exposing a profile view, wire it up fresh with a real route.