Extract the CI secrets install into a shared script - #25884
Open
mokagio wants to merge 2 commits into
Open
Conversation
`configure_apply` decrypts a single file, `Secrets.swift`, and its only consumer is the `GenerateCredentials.sh` Xcode build phase. The release-management and TestFlight-promotion jobs never invoke a compile, and take their App Store Connect, GitHub, and Slack credentials from Buildkite environment variables, so the decryption was dead weight there. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 5 <noreply@anthropic.com>
The upcoming move to a8c-secrets then swaps one call site instead of six. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors Buildkite pipelines to avoid decrypting CI secrets in jobs that don’t compile the app, and to centralize the remaining secrets install logic into a shared command script to reduce duplication ahead of the upcoming secrets-backend migration.
Changes:
- Removed
configure_applysecrets decryption from release-management and promotion jobs that don’t build the app. - Added a shared
.buildkite/commands/install-secrets.shand updated all build jobs to call it instead of inliningconfigure_apply. - Updated job step comments/logging to reflect that non-build jobs now only set up gems.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .buildkite/release-pipelines/update-app-store-strings.yml | Removes secrets install from App Store strings update pipeline step. |
| .buildkite/release-pipelines/publish-release.yml | Removes secrets install from publish release pipeline step. |
| .buildkite/release-pipelines/new-hotfix.yml | Removes secrets install from new hotfix pipeline step. |
| .buildkite/release-pipelines/new-beta-release.yml | Removes secrets install from new beta release pipeline step. |
| .buildkite/release-pipelines/code-freeze.yml | Removes secrets install from code-freeze pipeline step. |
| .buildkite/commands/release-build-wordpress.sh | Switches build job to shared install-secrets.sh. |
| .buildkite/commands/release-build-jetpack.sh | Switches build job to shared install-secrets.sh. |
| .buildkite/commands/prototype-build-wordpress.sh | Switches prototype build job to shared install-secrets.sh. |
| .buildkite/commands/prototype-build-jetpack.sh | Switches prototype build job to shared install-secrets.sh. |
| .buildkite/commands/build-for-testing.sh | Switches build-for-testing job to shared install-secrets.sh. |
| .buildkite/commands/build-and-upload-testflight.sh | Switches TestFlight build/upload job to shared install-secrets.sh. |
| .buildkite/commands/install-secrets.sh | New shared command that runs bundle exec fastlane run configure_apply. |
| .buildkite/commands/promote-nightly.sh | Removes secrets install from nightly promotion job (no build). |
| .buildkite/commands/promote-build-to-public.sh | Removes secrets install from public beta promotion job (no build). |
| .buildkite/commands/gather-testflight-candidates.sh | Removes secrets install from TestFlight candidate gathering job (no build). |
| .buildkite/commands/finalize-release.sh | Removes secrets install from finalize release job (no build). |
| .buildkite/commands/finalize-hotfix.sh | Removes secrets install from finalize hotfix job (no build). |
| .buildkite/commands/complete-code-freeze.sh | Removes secrets install from complete code freeze job (no build). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 33677 | |
| Version | PR #25884 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | a46dcd0 | |
| Installation URL | 3cju403gm49e0 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 33677 | |
| Version | PR #25884 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | a46dcd0 | |
| Installation URL | 4uh4avfasoku8 |
mokagio
commented
Aug 10, 2026
| @@ -0,0 +1,6 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| set -euo pipefail | |||
Contributor
Author
There was a problem hiding this comment.
Admittedly, only set -e is used. But, it seems okay to leave the other one set.
mokagio
enabled auto-merge
August 10, 2026 03:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Groundwork extracted from #25772 (AINFRA-1538) so the
a8c-secretsmigration lands as small, independently reviewable pieces.Two commits, reviewable separately:
configure_applydecrypts a single file,Secrets.swift, and its only consumer is theGenerateCredentials.shXcode build phase. The release-management and TestFlight-promotion jobs never invoke a compile so the decryption was dead weight in eleven places.install-secrets.sh, so the upcoming swap toa8c-secretstouches one call site instead of six.Testing instructions
AI-generated
The build jobs on this PR exercise commit 2 directly: prototype and build-for-testing steps must still produce signed builds with real credentials.
Commit 1 touches the release pipelines, which PR CI does not run. To review it, confirm that none of
complete_code_freeze,finalize_release,finalize_hotfix,gather_testflight_candidates,promote_build,promote_nightly,code_freeze,new_beta_release,new_hotfix_release,publish_release, orupdate_appstore_stringsreads from~/.configure.git grep 'configure/wordpress-ios'on trunk returns onlyGenerateCredentials.shand its.xcfilelist.CI so far only proves that the changes haven't broken the Prototype Builds. As for the other pipelines touched, we'll have to run them to have a tangible proof