Stop launching the WordPress app when Jetpack enables notifications - #25879
Open
crazytonyli wants to merge 2 commits into
Open
Stop launching the WordPress app when Jetpack enables notifications#25879crazytonyli wants to merge 2 commits into
crazytonyli wants to merge 2 commits into
Conversation
When the user allowed notifications in the Jetpack app with the WordPress app installed, JetpackNotificationMigrationService opened wordpressnotificationmigration:// to launch WordPress, disable its notifications, and bounce back via jetpacknotificationmigration://. The user saw Jetpack slide away to a (often signed-out) WordPress app and return, without asking for any of it (CMM-2224). The round trip no longer serves a purpose. The WordPress app disables its own notifications on every launch since the Jetpack features removal (PushNotificationsManager.setupRemoteNotifications unregisters when shouldPresentNotifications is false), and a signed-out WordPress app never registers a device token in the first place. Remove the Jetpack-side trigger and the migration flow copy that promised to disable WordPress notifications. Keep the WordPress-side URL handler so older Jetpack versions that still open the scheme get redirected back to Jetpack instead of stranding the user in WordPress. Fixes CMM-2224
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 33652 | |
| Version | PR #25879 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 4847e33 | |
| Installation URL | 5c0fhm13tbhag |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 33652 | |
| Version | PR #25879 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 4847e33 | |
| Installation URL | 4m5345ci08ueg |
jkmassel
approved these changes
Aug 8, 2026
jkmassel
left a comment
jkmassel
left a comment
Contributor
There was a problem hiding this comment.
LGTM – can we drop the LSApplicationQueriesSchemes entry from Info.plist as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The first commit is swift-format only. The actual change is in the second commit.
Description
Fixes https://linear.app/a8c/issue/CMM-2224
To reproduce the issue: With the WordPress app installed, install Jetpack, sign in, tap "Enable Notifications", and allow the system permission prompt. Jetpack opens the WordPress app (on its signed-out prologue) and bounces back, without the user asking for any of it. This only happens once per Jetpack install, which is why the original report couldn't reproduce it twice.
The bounce is
JetpackNotificationMigrationServiceopeningwordpressnotificationmigration://so the WordPress app can disable its own notifications, a Jetpack Focus era mechanism to prevent duplicate notifications. It no longer serves a purpose: since the Jetpack features removal, the WordPress app unregisters from notifications on every launch (PushNotificationsManager.setupRemoteNotifications), and a signed-out WordPress app never registers a device token at all.This PR removes the Jetpack-side trigger, plus the migration screen copy that promised the removed behavior ("We'll disable notifications for the WordPress app."). The WordPress-side URL handler is kept, so older Jetpack versions that still open the scheme get redirected back to Jetpack instead of stranding the user in WordPress. One accepted caveat: a WordPress install that hasn't launched since the features removal keeps its notification registration until it next launches; there is no way to clean that up from Jetpack without the app switch.