Custom Posts: Support "Access" and "Email to Subscribers" options#25574
Open
crazytonyli wants to merge 9 commits into
Open
Custom Posts: Support "Access" and "Email to Subscribers" options#25574crazytonyli wants to merge 9 commits into
crazytonyli wants to merge 9 commits into
Conversation
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 32271 | |
| Version | PR #25574 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 9805872 | |
| Installation URL | 65a5ge40dh0ho |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 32271 | |
| Version | PR #25574 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 9805872 | |
| Installation URL | 1cf44h2tlqh2g |
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
I recommend reviewing by commits. The first commit is pure code format changes and can be ignored.
Description
Fixes https://linear.app/a8c/issue/CMM-2069.
Custom Posts settings now support the same Jetpack newsletter options as regular Posts:
meta.This PR also fixes a bug where these two options remain visible even when the "Subscriptions" Jetpack module is not activated.
Testing instructions
"Subscriptions" Jetpack module must be activated, which is the case for all simple sites. For jetpack sites, you'll need to go to the Newsletter -> turn on "Let visitors subscribe to this site and receive emails when you publish a post".