Enable SwiftLint rule: redundant_nil_coalescing#25533
Draft
Conversation
Adds the rule to `only_rules`. SwiftLint --fix removed redundant `?? <value>` operators applied to non-optional expressions. Part of the Orchard SwiftLint rollout campaign. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 4.7 <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
…ening `swiftlint --fix` removed `?? nil` from expressions where the LHS was actually a double-optional (`String??`, `CGRect??`, etc.) — typically from `dict[key]` on a `[K: V?]` dictionary or `.map` on `Optional<T>` returning `Optional<U>`. The original `?? nil` flattened the result to a single optional; without it the call sites get a type error. For each broken call site: either rewrite to use `flatMap` (when that produces a clean single-optional) or restore the `?? nil` with a `swiftlint:disable:next redundant_nil_coalescing` suppression. The rule's autofix should arguably check for double optionals before stripping; until it does, this gives a working build. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables SwiftLint's
redundant_nil_coalescingrule.The rule flags
?? <default>applied to a non-optional value, which is redundant — the right-hand side can never be reached.swiftlint --fix.Part of the Orchard SwiftLint rollout campaign.
Test plan
swiftlint lint --strict --no-cacheis clean against the rule.🤖 Generated with Claude Code