Enable SwiftLint rule: contains_over_range_nil_comparison#25524
Draft
Enable SwiftLint rule: contains_over_range_nil_comparison#25524
Conversation
Adds the rule to `only_rules`. The rule prefers `s.contains(...)` over `s.range(of:) != nil` (and the `== nil` inverse), which is a clarity win. Part of the Orchard SwiftLint rollout campaign. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 4.7 <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 32100 | |
| Version | PR #25524 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | bb688f9 | |
| Installation URL | 1np092fi7f0no |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 32100 | |
| Version | PR #25524 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | bb688f9 | |
| Installation URL | 4piohq6bpcvj0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables SwiftLint's
contains_over_range_nil_comparisonrule.The rule prefers
s.contains(...)overs.range(of:) != nil(and== nil), which is a clarity win.Part of the Orchard SwiftLint rollout campaign.
Test plan
swiftlint lint --strict --no-cacheis clean against the rule.🤖 Generated with Claude Code