Enable SwiftLint rule: contains_over_first_not_nil#25523
Draft
Enable SwiftLint rule: contains_over_first_not_nil#25523
Conversation
Adds the rule to `only_rules` and rewrites the 13 existing violations:
- `xs.first(where: { ... }) != nil` → `xs.contains(where: { ... })`
- `xs.first { ... } == nil` patterns rewritten using the equivalent
`!contains` / `allSatisfy` form, depending on what reads cleanest.
The rewrite is type-preserving (Bool→Bool) — local build deferred to CI.
Part of the Orchard SwiftLint rollout campaign.
---
Generated with the help of Claude Code, https://claude.ai/code
Co-Authored-By: Claude Code Opus 4.7 <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 32099 | |
| Version | PR #25523 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 86157be | |
| Installation URL | 77jeinuoimd60 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 32099 | |
| Version | PR #25523 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 86157be | |
| Installation URL | 0nqsd7tkl6tjg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables SwiftLint's
contains_over_first_not_nilrule and rewrites the 13 existing violations.The rule prefers
xs.contains { ... }overxs.first(where: { ... }) != nil(and thefirstIndexvariant), which is a performance and clarity win.first { } == nil) were rewritten with!contains/allSatisfydepending on what reads cleanest.Part of the Orchard SwiftLint rollout campaign.
Test plan
swiftlint lint --strict --no-cacheis clean against the rule.🤖 Generated with Claude Code