-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Ads tab #25145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Add Ads tab #25145
Conversation
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30485 | |
| Version | PR #25145 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | b998d6f | |
| Installation URL | 4ok4llqfgqir0 |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30485 | |
| Version | PR #25145 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | b998d6f | |
| Installation URL | 187mqo3q99r60 |
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
a38ad86 to
c3b1812
Compare
| // MARK: - Helpers | ||
|
|
||
| /// Returns the current blog from SiteStatsInformation if available | ||
| private static func currentBlog() -> Blog? { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not ideal, but this is how this screen operates. I don't want to refactor it in the scope of this PR.
| /// Enumeration that contains all of the Blog's available capabilities. | ||
| /// | ||
| public enum Capability: String { | ||
| case ActivateWordAds = "activate_wordads" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not using it yet, but I decided to model it anyway since I spent a bit of time discovering it.
08a5b43 to
b998d6f
Compare
|





This initial PR adds an empty
AdsTabViewfor sites that have WordAds module enabled.Note: I opened CMM-1132: Add WordAds ads revenue stats to Jetpack app to improve who
AdaptiveTabBarperforms sizing if the content doesn't fit.Screenshots
Testing instructions