CMM-2200: Open new stats from the My Site stats card - #23174
Draft
nbradbury wants to merge 4 commits into
Draft
Conversation
The new stats gate lived only in ListItemActionHandler, so the Today's Stats card always opened legacy stats. Extract the gate into NewStatsFeatureUtils and apply it to the card and the post-login path.
Collaborator
Generated by 🚫 Danger |
The class under test is a single boolean OR with no branching logic, and the routing it feeds is already covered at both call sites.
Contributor
|
|
Contributor
|
|
This comment was marked as resolved.
This comment was marked as resolved.
The lint baseline covers exactly five DoNotMockDataClass hits in this file, so the three added mocks failed lint. These tests only exercise the click callbacks, so the nullable model can just be null.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #23174 +/- ##
=======================================
Coverage 37.84% 37.84%
=======================================
Files 2345 2346 +1
Lines 127530 127538 +8
Branches 17716 17718 +2
=======================================
+ Hits 48258 48264 +6
- Misses 75313 75315 +2
Partials 3959 3959 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Tapping the Today's Stats card on My Site opened the old Stats screen even when New Stats was enabled. \
Testing instructions
Injected period does not clobber the saved one: