Exclude fastlane store metadata from CODEOWNERS#22981
Conversation
The `fastlane/` rule routed per-locale store-listing folders to apps-infra-tooling, pinging the team on translation-only release churn. Disown them with owner-less overrides; tooling under fastlane/ stays owned. --- Generated with the help of Claude Code, https://claude.com/claude-code Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates CODEOWNERS to stop requesting infra-tooling reviews for translation-only changes under Fastlane store metadata folders.
Changes:
- Adds comments explaining why store-listing localization folders should not be owned.
- Attempts to “disown”
fastlane/metadata/andfastlane/jetpack_metadata/via owner-less CODEOWNERS patterns.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| fastlane/ @wordpress-mobile/apps-infra-tooling | ||
| # Store-listing localization is content, not infra — disown it to avoid | ||
| # pinging the team on translation-only release churn. | ||
| fastlane/metadata/ | ||
| fastlane/jetpack_metadata/ |
There was a problem hiding this comment.
I think this is a false positive. GitHub’s CODEOWNERS documentation explicitly shows ownerless child entries overriding a broader owned directory: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-syntax
The example there uses /apps/ @octocat followed by /apps/github to leave the child path without an owner. This PR is applying the same pattern to fastlane/metadata/ and fastlane/jetpack_metadata/.
We’ll merge this, see how GitHub behaves in practice, and follow up if needed.
Posted by Codex (GPT-5) on behalf of @mokagio with approval.
Per review on simplenote-android#1823: the classification is the non-obvious bit; the mechanism and motivation are restatement / PR material. --- Generated with the help of Claude Code, https://claude.com/claude-code Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
|
|
|
Removes the fastlane metadata localization folders from the @apps-infra-tooling purview. The localization contents are not infra, while it would be simpler to keep the whole
fastlane/folder in the rule, our team receives a lot of pings viaCODEOWNERSnow, so I feel being specific will help.AI-generated details
The
fastlane/CODEOWNERS rule claims the per-locale store-listing folders, so release-merge PRs that only bump localized changelogs request review from@wordpress-mobile/apps-infra-toolingfor nothing — see #22980, which touched onlyfastlane/metadata/andfastlane/jetpack_metadata/.This disowns those folders with owner-less overrides. A CODEOWNERS pattern with no owner removes ownership, and last-match-wins keeps it ahead of the broad
fastlane/rule, so tooling underfastlane/(Fastfile, lanes, resources) stays owned.Part of the
codeowners-metadatawave (AINFRA-2437); sibling repos with still-open routing PRs got the same change folded in.How to test
In the repo's CODEOWNERS view, a file under
fastlane/metadata/shows no owner, whilefastlane/Fastfilestill shows@wordpress-mobile/apps-infra-tooling.Posted by Claude Code (Opus 4.8) on behalf of @mokagio with approval.