[Tooling] Update PO files generation using latest release-toolkit#16502
[Tooling] Update PO files generation using latest release-toolkit#16502
Conversation
iangmaia
added
the
category: tooling
iangmaia
requested review from
AliSoftware,
mokagio and
twstokes
and removed request for
AliSoftware
iangmaia
force-pushed
the
iangmaia/update-po-files-generation
branch
2 times, most recently
from
86fb77f to
b6aba23
Compare
mokagio
left a comment
mokagio
left a comment
There was a problem hiding this comment.
Good to go.
Approving to unblock. It'd be great to wait till the release-toolkit changes are merged and shipped before merging this, though.
| @@ -331,27 +331,70 @@ platform :ios do | |||
| lane :update_app_store_strings do |options| | |||
| source_metadata_folder = File.join(FASTLANE_DIR, 'appstoreres', 'metadata', 'source') | |||
There was a problem hiding this comment.
Should we use this as the occasion to get rid of the confusing appstoreres/ folder in favor of the standard Fastlane metadata/default?
Fine by me to move one thing at a time, though. I just noticed this because I went to edit a file in metadata/default to test locally and did not see the po change other than in the timestamp.
There was a problem hiding this comment.
Fine by me to move one thing at a time, though.
Actually, in working on fixes for missing text in screenshots, I found myself dropping appstoreres for metadata. See #16531. Once this lands, I'll update my PR and complete the removal.
There was a problem hiding this comment.
…StoreStrings.pot
iangmaia
force-pushed
the
iangmaia/update-po-files-generation
branch
from
b6aba23 to
8af283b
Compare
iangmaia
force-pushed
the
iangmaia/update-po-files-generation
branch
from
ad453ba to
a3c637d
Compare
Co-authored-by: Gio Lodi <gio@mokacoding.com>
iangmaia
force-pushed
the
iangmaia/update-po-files-generation
branch
from
a3c637d to
160ad57
Compare
3 participants
Description
Updates the project to use the updated PO generation, using
gp_update_metadata_sourceinstead of the now deprecatedios_update_metadata_source(see wordpress-mobile/release-toolkit#684).Test Steps
You can try making changes to comments in
update_app_store_strings, revert the changes fromAppStoreStrings.potand runbundle exec fastlane update_app_store_stringsand make sure the file is properly generated again.