Increase test coverage for PQC and CMake #9637
Merged
+187
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frauschi
force-pushed
the
test_coverage
branch
3 times, most recently
from
28edd71 to
1eeae37
Compare
Frauschi
force-pushed
the
test_coverage
branch
4 times, most recently
from
eed1a9e to
d794ad8
Compare
Contributor
Author
|
retest this please |
Frauschi
force-pushed
the
test_coverage
branch
from
d794ad8 to
bccc6db
Compare
Contributor
Author
|
I think the remaining failing CI tests are unrelated to this PR. |
Contributor
|
Jenkins retest this please |
Frauschi
force-pushed
the
test_coverage
branch
from
bccc6db to
b4e8473
Compare
Contributor
Author
|
Jenkins retest this please |
douzzer
previously requested changes
Jan 16, 2026
Contributor
douzzer
left a comment
douzzer
left a comment
There was a problem hiding this comment.
Minor questions+quibbles.
Looks good otherwise.
Frauschi
force-pushed
the
test_coverage
branch
from
b4e8473 to
08a5694
Compare
Contributor
Author
I addressed the CMake gate thing in the updated commit. The options in the PQ build are beneficial in my view, see comments. |
Contributor
Author
|
Retest this please |
* More PQC configurations * More CMake setups * Fix various bugs uncovered by these tests Added some missing feature additions to CMake to make the example `user_settings_all.` config file work for the CI test.
Frauschi
force-pushed
the
test_coverage
branch
from
08a5694 to
14ce795
Compare
Contributor
Author
|
Jenkins restest this please |
dgarske
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase test coverage, mainly for stuff related to #9605 and #9608
These are mainly
SMALLconfigurations or some edge cases, which have been missing up to now but already caused some build failures (e.g. #9608).Added the functionality added in #9605 to the existing CMake CI tests. Also added a new test to verify the
user_settings.hfunctionality with CMake. For that, some missing features have been added to CMake to make the exampleexample/configs/user_settings_all.hconfig file work for the CI test.