Set actual date length in CRL ASN1_TIME fields

[kojo1]

Description

lastDateAsn1/nextDateAsn1 used MAX_DATE_SIZE as the ASN1_TIME length
instead of the real date string length, breaking ASN1_TIME_check()
and date printing/comparison on X509_CRL_get0_lastUpdate()/
get0_nextUpdate(). Set the length with XSTRLEN() and add
ASN1_TIME_check() coverage to test_wolfSSL_X509_CRL().

Fixes zd#22281

Testing

Added length check on the time.

Checklist

• added tests
• updated/added doxygen
• updated appropriate READMEs
• Updated manual and documentation

[github-actions]

MemBrowse Memory Report

gcc-arm-cortex-m0plus

• FLASH: .text +48 B (+0.1%, 64,883 B / 262,144 B, total: 25% used)

gcc-arm-cortex-m3

• FLASH: .text +56 B (+0.0%, 123,579 B / 262,144 B, total: 47% used)

gcc-arm-cortex-m4-crypto-only

• FLASH: .text +64 B (+0.0%, 175,978 B / 262,144 B, total: 67% used)

gcc-arm-cortex-m4-min-ecc

• FLASH: .text +64 B (+0.1%, 62,405 B / 262,144 B, total: 24% used)

gcc-arm-cortex-m4-openssl-compat

• FLASH: .text +128 B (+0.0%, 775,612 B / 1,048,576 B, total: 74% used)

gcc-arm-cortex-m4-pkcs7

• FLASH: .text +64 B (+0.0%, 214,830 B / 262,144 B, total: 82% used)

gcc-arm-cortex-m4-pq

• FLASH: .text +64 B (+0.0%, 297,628 B / 1,048,576 B, total: 28% used)

gcc-arm-cortex-m4-sp-math

• FLASH: .text +64 B (+0.1%, 62,405 B / 262,144 B, total: 24% used)

gcc-arm-cortex-m4-tls12

• FLASH: .text +64 B (+0.1%, 124,339 B / 262,144 B, total: 47% used)

gcc-arm-cortex-m4-tls13

• FLASH: .text +64 B (+0.0%, 238,369 B / 262,144 B, total: 91% used)

gcc-arm-cortex-m7-pq

• FLASH: .text +64 B (+0.0%, 298,524 B / 1,048,576 B, total: 28% used)

gcc-arm-cortex-m7-tls13

• FLASH: .text +64 B (+0.0%, 238,433 B / 262,144 B, total: 91% used)

linuxkm-pie

• Data: __patchable_function_entries +8 B (+0.0%, 26,568 B)
  No memory changes detected for:
• gcc-arm-cortex-m4
• gcc-arm-cortex-m4-baremetal
• gcc-arm-cortex-m4-dtls13
• gcc-arm-cortex-m4-rsa-only
• gcc-arm-cortex-m7
• linuxkm-standard
• stm32-sim-stm32h753

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #11151

Scan targets checked: wolfssl-bugs
Failed targets: wolfssl-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

[Copilot]

Pull request overview

This PR fixes OpenSSL-compat CRL time handling by setting WOLFSSL_ASN1_TIME.length to the actual date string length (instead of MAX_DATE_SIZE), restoring correct behavior for ASN1_TIME_check() and consumers of X509_CRL_get0_lastUpdate() / X509_CRL_get0_nextUpdate().

Changes:

• Set CRL_Entry’s lastDateAsn1.length / nextDateAsn1.length based on the stored date string length rather than MAX_DATE_SIZE.
• Add API test coverage that validates CRL last/next update times pass ASN1_TIME_check() (when ASN time support is enabled).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
tests/api.c	Adds test assertions to validate CRL ASN1_TIME objects pass ASN1_TIME_check().
src/crl.c	Fixes CRL entry ASN1_TIME length initialization to use the real date string length.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[kojo1]

Thanks for catching that — updated.

The nextUpdate check is now guarded on non-NULL. lastUpdate (thisUpdate, mandatory per RFC 5280 §5.1) is still checked unconditionally.

[kojo1]

Good catch — you are right that the buffer is not guaranteed to be
NUL-terminated.　Replaced XSTRLEN() with a bounded scan.