.github/scripts/parallel-make-check.py: emit literal status emoji, not :shortcodes:#10781
Open
julek-wolfssl wants to merge 1 commit into
Open
.github/scripts/parallel-make-check.py: emit literal status emoji, not :shortcodes:#10781julek-wolfssl wants to merge 1 commit into
julek-wolfssl wants to merge 1 commit into
Conversation
…t :shortcodes:
The summary table is printed to plain stdout (the Actions console log and
local terminals) in addition to the GitHub step summary. GitHub emoji
:shortcodes: like :heavy_minus_sign: only expand on GitHub's Markdown
surfaces, so in the console log they appeared as literal text. Emit the
Unicode emoji directly, via \N{...} escapes so the source stays ASCII; the
glyphs match what the shortcodes mapped to, leaving the step summary
unchanged.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the parallel-make-check.py CI helper’s summary table output so status icons render correctly both in the GitHub step summary and in plain stdout (Actions console logs and local terminals).
Changes:
- Replace GitHub emoji
:shortcodes:in the summary table with literal Unicode emoji via\N{...}escapes. - Preserve the existing visual meaning of pass/fail/aborted/warn indicators across outputs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
parallel-make-check.pysummary table is printed both to the GitHubstep summary and to plain stdout (the Actions console log and local
terminals). GitHub emoji
:shortcodes:like:heavy_minus_sign:onlyexpand on GitHub's Markdown surfaces, so in the console log they showed up
as literal
:shortcode:text.Emit the Unicode emoji directly instead, using
\N{...}escapes so thesource stays ASCII. The glyphs match what the shortcodes mapped to, so the
rendered step summary is unchanged while the console log now shows real
status icons.